UpdateDelegate Change UA/Collection

[blockiosaurus]

Adding the ability to change the update authority or collection as the update delegate.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mpl-core-js-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 28, 2025 8:38pm

[github-actions]

Benchmark

Benchmark suite	Current: 8d8db08	Previous: f569292	Ratio
CU: create a new, empty asset	11206 Compute Units	11206 Compute Units	1
Space: create a new, empty asset	91 Bytes	91 Bytes	1
CU: create a new, empty asset with empty collection	22681 Compute Units	22681 Compute Units	1
Space: create a new, empty asset with empty collection	91 Bytes	91 Bytes	1
CU: create a new asset with plugins	35182 Compute Units	35182 Compute Units	1
Space: create a new asset with plugins	194 Bytes	194 Bytes	1
CU: create a new asset with plugins and empty collection	41202 Compute Units	41202 Compute Units	1
Space: create a new asset with plugins and empty collection	194 Bytes	194 Bytes	1
CU: list an asset	28101 Compute Units	28101 Compute Units	1
CU: sell an asset	44473 Compute Units	44473 Compute Units	1
CU: list an asset with empty collection	35663 Compute Units	35663 Compute Units	1
CU: sell an asset with empty collection	56825 Compute Units	56825 Compute Units	1
CU: list an asset with collection royalties	36434 Compute Units	36434 Compute Units	1
CU: sell an asset with collection royalties	61909 Compute Units	61909 Compute Units	1
CU: transfer an empty asset	6444 Compute Units	6444 Compute Units	1
CU: transfer an empty asset with empty collection	9043 Compute Units	9043 Compute Units	1
CU: transfer an asset with plugins	14769 Compute Units	14769 Compute Units	1
CU: transfer an asset with plugins and empty collection	17368 Compute Units	17368 Compute Units	1

This comment was automatically generated by workflow using github-action-benchmark.

[blockiosaurus]

Huge thanks to @ASCorreia for his work on #217 regarding #208.

[danenbm]

Approved with comment to check

PR Overview

This PR updates the update delegate logic to enable changing the update authority or collection by the update delegate while modifying client tests to verify the new behavior.

• Modified conditional logic in the update delegate plugin to distinguish between asset and collection update rules.
• Adjusted client tests (both in updateV2 and plugin tests) to assert state changes instead of expecting errors.
• Updated the processor’s authority checks to ensure consistency with the new behavior.

Reviewed Changes

File	Description
programs/mpl-core/src/plugins/internal/authority_managed/update_delegate.rs	Updated update delegate plugin logic to handle asset and collection authority updates with revised conditionals.
clients/js/test/updateV2.test.ts	Modified tests to assert asset state after update operations in line with new delegate behavior.
clients/js/test/plugins/collection/updateDelegate.test.ts	Changed tests for collection update authority to reflect the new allowed behaviors.
clients/js/test/plugins/asset/updateDelegate.test.ts	Revised tests for asset update authority updates via update delegate to assert state updates.
programs/mpl-core/src/processor/update.rs	Adjusted authority check syntax in processor logic to align with updated delegate conditions.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

programs/mpl-core/src/plugins/internal/authority_managed/update_delegate.rs:165

• [nitpick] Consider adding explicit parentheses around the combined conditions to clarify the intended logical grouping and improve readability.

if (ctx.resolved_authorities.is_some() && ctx.resolved_authorities.unwrap().contains(ctx.self_authority)

programs/mpl-core/src/plugins/internal/authority_managed/update_delegate.rs:182

• [nitpick] Consider caching the results of unwrap() calls for ctx.new_asset_authority and ctx.collection_info to enhance readability and reduce repetitive calls.

&& ctx.new_asset_authority.unwrap() != &UpdateAuthority::Collection(*ctx.collection_info.unwrap().key)

programs/mpl-core/src/processor/update.rs:226

• [nitpick] Ensure that using authority.key without the '&' is consistent with the type requirements of additional_delegates.contains; adding a comment to document this intentional change could help future maintainers.

&& !plugin.additional_delegates.contains(authority.key)