Implemented memory allocation strategy for different prediction types #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the fail in 17, macos-11 is related to microsoft/LightGBM#4229 but I am not sure how can I fix that. Maybe downgrading the libomp as the issue suggests? |
|
The issue you've mentioned seems to be specific to macos-12. Re-running the CI seems to hint that it's some sort of flaky test. |
|
@popovstefan I've made a minor release https://github.com/metarank/lightgbm4j/releases/tag/3.3.2-2 with your fix. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to use the library in a real-time streaming application and got random memory leak errors. Debugged and noticed that for each prediction type we allocate the same memory for the output result, but it should be different. See the notes at the following links:
In this pull request I have implemented a method to dynamically determine the memory needed for the output result based on the prediction type (at the bottom of the LGBMBooster.java class). I have also written tests for all possible prediction types.