(v0.5 backport) lib: fix behavior with util.inspect #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one tried to print the result of `require('metarhia-jstp')` in
general or the `Connection` class itself to console, it resulted in
invocation of internal logic of the `Connection` and crashing with
an exception.
A similar issue had been fixed in
f7c393b and
76e4323 but was introduced again in
4a7941a.
Backport-of: #72
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
If one tried to print the result of `require('metarhia-jstp')` in
general or the `Connection` class itself to console, it resulted in
invocation of internal logic of the `Connection` and crashing with
an exception.
A similar issue had been fixed in
f7c393b and
76e4323 but was introduced again in
4a7941a.
Backport-of: #72
PR-URL: #114
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in 04ada2e. |
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
If one tried to print the result of `require('metarhia-jstp')` in
general or the `Connection` class itself to console, it resulted in
invocation of internal logic of the `Connection` and crashing with
an exception.
A similar issue had been fixed in
f7c393b and
76e4323 but was introduced again in
4a7941a.
Backport-of: #72
PR-URL: #114
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
If one tried to print the result of `require('metarhia-jstp')` in
general or the `Connection` class itself to console, it resulted in
invocation of internal logic of the `Connection` and crashing with
an exception.
A similar issue had been fixed in
f7c393b and
76e4323 but was introduced again in
4a7941a.
Backport-of: #72
PR-URL: #114
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one tried to print the result of
require('metarhia-jstp')ingeneral or the
Connectionclass itself to console, it resulted ininvocation of internal logic of the
Connectionand crashing withan exception.
A similar issue had been fixed in
f7c393b and
76e4323 but was introduced again in
4a7941a.
Backport-of: #72