-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.5.2 proposal #118
v0.5.2 proposal #118
Conversation
This commit adds explicit type casts to resolve compiler warnings about possible data loss.
Rename Object Serialization example from `person.jsrs` into `person.js` and add a missing Record Serialization example under that name.
Remove the unnecessary "All rights reserved" phrase since the last country which laws used to required it got rid of it in 2000 and it has meant nothing throughout the rest of the world since very long time ago.
* Replace license text with references to the LICENSE files. * Update years.
* Split `jsrs-impl.cc` into separate modules. * Make some refactoring. * Rename the native addon to `jstp` since there already is a function that is not a part of JSRS. * Fix `binding.gyp`: make `cflags` not ignored on macOS (as it appeared they used to be) and do not use `-O3` in Debug configuration. * Use a macro to throw V8 exceptions to avoid boilerplate code. Backport-of: #36 PR-URL: #110
Fix compilation error caused by missing `<cstddef>` header needed for `std::size_t` type. PR-URL: #64
* Use `cflags_cc` instead of `cflags`. * By default `node-gyp` uses `-std=gnu++0x`. This commit modifies `cflags_cc` to use `-std=c++11`. PR-URL: #37
s/Successfull/Successful PR-URL: #55
* Eliminate unnecessary assignments. * Encode control characters in place to avoid copying and memory allocations. * Fix possible memory leak. PR-URL: #66
In order to communicate with developers of alternative implementations and be reasonable about compatibility, we need to assign versions to the protocol too. This commit documents the protocol versioning policy. PR-URL: #56
This entry was copied from .gitignore file of Impress (as the whole file was copied) at some time in the beginning of the project. I guess, it had been used by @tshemsedinov long time ago, but now Impress itself doesn't have such entry in its ignore-files. The next step will be to review my `dev/` directory, remove the helpers that I don't need anymore and refactor the rest of them to publicly available tests and tools to be placed in the corresponding directories of the repository. PR-URL: #83
PR-URL: #103 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
The common implementation of `application.callMethod()` involves checking `args.length` which leads to crash if `args` is null or undefined. This commit provides a quick-and-dirty patch for only this vulnerability until the common approach for message sanity checking will have been developed. PR-URL: #100
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52 PR-URL: #113 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
In my opinion we should backport the patches concerning bitHound errors. |
PR-URL: #119 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
This is kind of backports PR #105 in a different way, and this way might be even better than that the original commit used. The reason of doing this for v0.5, besides fixing a bug, is the fact that we cannot use metasync in v0.5 since it is not compatible with old Node.js versions while old library versions that used to be are too outdated and even get reported by bitHound as insecure. Backport-of: #105 PR-URL: #120 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub done. The only bitHound error we'll have for v0.5 now is the stale webpack devDependency, which we, unfortunately, cannot upgrade in this release for compatibility reasons. That's not critical, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a backport release that brings the most essential changes and bugfixes from v0.6 to currently used in at least one real project v0.5. Notable changes: * parser: fix memory leaks (Alexey Orlenko) * parser: fix bugs in JSRS parser (Alexey Orlenko) * src,build: improve the native module subsystem (Alexey Orlenko) * build: compile in ISO C++11 mode (Alexey Orlenko) * parser: fix a possible memory leak (Alexey Orlenko) * parser: make parser single-pass (Mykola Bilochub) * parser: improve string parsing (Mykola Bilochub) * parser: fix bug causing node to crash (Mykola Bilochub) * connection: check that method arguments exist (Alexey Orlenko) PR-URL: #118 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
This is a backport release that brings the most essential changes and bugfixes from v0.6 to currently used in at least one real project v0.5. Notable changes: * parser: fix memory leaks (Alexey Orlenko) * parser: fix bugs in JSRS parser (Alexey Orlenko) * src,build: improve the native module subsystem (Alexey Orlenko) * build: compile in ISO C++11 mode (Alexey Orlenko) * parser: fix a possible memory leak (Alexey Orlenko) * parser: make parser single-pass (Mykola Bilochub) * parser: improve string parsing (Mykola Bilochub) * parser: fix bug causing node to crash (Mykola Bilochub) * connection: check that method arguments exist (Alexey Orlenko) PR-URL: #118 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
This is a backport release that brings the most essential changes and bugfixes from v0.6 to currently used in at least one real project v0.5. Notable changes: * parser: fix memory leaks (Alexey Orlenko) * parser: fix bugs in JSRS parser (Alexey Orlenko) * src,build: improve the native module subsystem (Alexey Orlenko) * build: compile in ISO C++11 mode (Alexey Orlenko) * parser: fix a possible memory leak (Alexey Orlenko) * parser: make parser single-pass (Mykola Bilochub) * parser: improve string parsing (Mykola Bilochub) * parser: fix bug causing node to crash (Mykola Bilochub) * connection: check that method arguments exist (Alexey Orlenko) PR-URL: #118 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
This is a backport release that brings the most essential changes and bugfixes from v0.6 to currently used in at least one real project v0.5. Notable changes: * parser: fix memory leaks (Alexey Orlenko) * parser: fix bugs in JSRS parser (Alexey Orlenko) * src,build: improve the native module subsystem (Alexey Orlenko) * build: compile in ISO C++11 mode (Alexey Orlenko) * parser: fix a possible memory leak (Alexey Orlenko) * parser: make parser single-pass (Mykola Bilochub) * parser: improve string parsing (Mykola Bilochub) * parser: fix bug causing node to crash (Mykola Bilochub) * connection: check that method arguments exist (Alexey Orlenko) PR-URL: #118 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Version 0.5.2 (2017-03-03, @aqrln)
This is a backport release that brings the most essential changes and bugfixes
from v0.6 to currently used in at least one real project v0.5.
Notable changes:
All changes:
switch
statements (Mykola Bilochub) #62