Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v0.5 backport) server: handle connection errors before handshake #115

Closed
wants to merge 1 commit into from
Closed

(v0.5 backport) server: handle connection errors before handshake #115

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Apr 2, 2017

This commit fixes a critical issue that allowed to crash the server
with an unhandled error event sending an invalid packet that causes
parser error before a handshake.

Fixes: #76
Backport-of: #78

@aqrln
server: handle connection errors before handshake
9b99771 
This commit fixes a critical issue that allowed to crash the server
with an unhandled error event sending an invalid packet that causes
parser error before a handshake.

Fixes: #76
Backport-of: #78
@aqrln aqrln requested a review from belochub April 2, 2017 18:05
belochub
belochub approved these changes Apr 2, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aqrln added a commit that referenced this pull request Apr 2, 2017
@aqrln
server: handle connection errors before handshake
8186278 
This commit fixes a critical issue that allowed to crash the server
with an unhandled error event sending an invalid packet that causes
parser error before a handshake.

Fixes: #76
Backport-of: #78
PR-URL: #115
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Apr 2, 2017

Landed in 8186278.

@aqrln aqrln closed this Apr 2, 2017
@aqrln aqrln deleted the v0.5-backport-pr78 branch April 2, 2017 18:56
aqrln added a commit that referenced this pull request Apr 2, 2017
@aqrln
server: handle connection errors before handshake
74912ba 
This commit fixes a critical issue that allowed to crash the server
with an unhandled error event sending an invalid packet that causes
parser error before a handshake.

Fixes: #76
Backport-of: #78
PR-URL: #115
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 3, 2017
@aqrln
server: handle connection errors before handshake
bbd66e0 
This commit fixes a critical issue that allowed to crash the server
with an unhandled error event sending an invalid packet that causes
parser error before a handshake.

Fixes: #76
Backport-of: #78
PR-URL: #115
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
@aqrln aqrln mentioned this pull request Apr 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belochub belochub belochub approved these changes

Assignees
No one assigned
Labels
bug connection security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqrln @belochub