(v0.5 backport) lint: backport bitHoud-related commits #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
changed the title
This is a backport of eb49729.
This is kind of backports PR #105 in a different way, and this way might be even better than that the original commit used. The reason of doing this for v0.5, besides fixing a bug, is the fact that we cannot use metasync in v0.5 since it is not compatible with old Node.js versions while old library versions that used to be are too outdated and even get reported by bitHound as insecure. Backport-of: #105
Original commit: 16d8c85
Backport of eafafd1.
Original commit: 6069f18.
|
@belochub bitHoud is now happy, can you please take a look at this PR? |
|
CI fails with some errors during installation. Can you check this out, please? |
|
Ugh... messed up with resolving conflicts in cc78133. |
Update the Markdown linting tools. Backport-of: #87
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
This is kind of backports PR #105 in a different way, and this way might be even better than that the original commit used. The reason of doing this for v0.5, besides fixing a bug, is the fact that we cannot use metasync in v0.5 since it is not compatible with old Node.js versions while old library versions that used to be are too outdated and even get reported by bitHound as insecure. Backport-of: #105 PR-URL: #120 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
|
For the record: Travis and bitHound linter passing, bitHound dependency checker complains at stale webpack devDependency we cannot upgrade for v0.5. |
Merged
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
This is kind of backports PR #105 in a different way, and this way might be even better than that the original commit used. The reason of doing this for v0.5, besides fixing a bug, is the fact that we cannot use metasync in v0.5 since it is not compatible with old Node.js versions while old library versions that used to be are too outdated and even get reported by bitHound as insecure. Backport-of: #105 PR-URL: #120 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failing bitHoud checks for v0.5.