Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: update remark #87

Closed
wants to merge 1 commit into from
Closed

lint: update remark #87

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 26, 2017

Update the Markdown linting tools.

@aqrln
lint: update remark
086a0e3 
Update the Markdown linting tools.
@aqrln aqrln added the test label Feb 26, 2017
@tshemsedinov
Copy link
Member

@aqrln I think such changes may pass without PR/review

belochub
belochub approved these changes Feb 26, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aqrln added a commit that referenced this pull request Feb 26, 2017
@aqrln
lint: update remark
691795b 
Update the Markdown linting tools.

PR-URL: #87
@aqrln
Copy link
Member Author

aqrln commented Feb 26, 2017

Landed in 691795b.

@aqrln aqrln closed this Feb 26, 2017
@aqrln aqrln deleted the update-remark branch February 26, 2017 13:03
@aqrln
Copy link
Member Author

aqrln commented Feb 26, 2017 •
edited
Loading

@tshemsedinov IMO, if something is about to go to master, someone has to check it, even changes so little can bring something unexpected, especially since it this concrete case a dependency is updated to the next semver-major version. That's the first point that covers the necessity of review and it may be arguable. The second point is about PRs themselves: even if one doesn't want for changes to be reviewed, a PR must be opened anyway because we have CI only build pull requests and our release preparation tooling relies on the PRs, labels in these PRs and commit metadata.

aqrln added a commit that referenced this pull request Mar 13, 2017
@aqrln
lint: update remark
ca1e7a1 
Update the Markdown linting tools.

PR-URL: #87
@aqrln aqrln mentioned this pull request Mar 13, 2017
Merged
aqrln added a commit that referenced this pull request Mar 13, 2017
@aqrln
lint: update remark
57c10ae 
Update the Markdown linting tools.

PR-URL: #87
aqrln added a commit that referenced this pull request Apr 3, 2017
@aqrln
lint: update remark
cc78133 
Update the Markdown linting tools.

Backport-of: #87
aqrln added a commit that referenced this pull request Apr 3, 2017
@aqrln
lint: update remark
29600c5 
Update the Markdown linting tools.

Backport-of: #87
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
lint: update remark
6282e19 
Update the Markdown linting tools.

PR-URL: #87
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
lint: update remark
e81f02d 
Update the Markdown linting tools.

PR-URL: #87
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belochub belochub belochub approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aqrln @tshemsedinov @belochub