-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools,meta: make AUTHORS reflect all the contributors #88
Conversation
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file with proper names and emails of active collaborators. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only.
AUTHORS
Outdated
@@ -1,3 +1,6 @@ | |||
Timur Shemsedinov <timur.shemsedinov@gmail.com> | |||
Dimon Durak <Dimon Durak> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimon-durak can you please provide your real name and email if you want to be included to the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimon-durak ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dmitry Borisov
dimon.durak@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've added an entry for you in .mailmap
and regenerated the list of contributors.
AUTHORS
Outdated
Alexey Orlenko <eaglexrlnk@gmail.com> | ||
Mykola Bilochub <nbelochub@gmail.com> | ||
Vlad <Dzyubavlad@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DzyubSpirit please check if you email is correct here. And how would you prefer your full name to be spelled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Email is correct and I prefer to be Dzyuba WhatIsLove.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DzyubSpirit I think we prefer real names unless you have strong reasons to not be called Vlad Dzyuba. I was asking about the correct spelling of your last name, actually :)
What about email, maybe I should have been more explicit too: the question is whether it should be written with a capital letter or I can lowercase it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aqrln, okey. Right spelling of my last name is Dziuba. Let it be this way. My email case does not matter, so you can do what it is needed with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DzyubSpirit done.
* Don't use a Set together with an array, O(n^2) instead of O(n*log(n)) is fine for such tool but the code is shorter. * Use a regular for-of loop instead of reduce.
New commit message for 8915cd7: tools: generate authors list automatically * Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case) and proper names and emails for two contributors who committed with invalid ones.
ping @belochub @tshemsedinov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tshemsedinov ping |
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case) and proper names and emails for two contributors who committed with invalid ones should be placed there. PR-URL: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. Backport-of: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: #88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: #88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: metarhia/jstp#88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: metarhia/jstp#88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: metarhia/jstp#88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: metarhia/jstp#88
* Add new `update-authors.js` tool that traverses commit history using `git log` and creates authors list. * Decouple common functions into a module shared between tools. * Add `.mailmap` file. This file is automatically parsed by Git so that `git log --format='%aN <%aE>'` won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only. This file now includes the active collaborators (@tshemsedinov for a reason and @aqrln and @belochub just in case), proper names and emails of contributors who committed with invalid ones should be placed here. PR-URL: metarhia/jstp#88
* Add all the contributors using `tools/update-authors.js`. * Sort the mail map alphabetically. PR-URL: metarhia/jstp#88
Right now we only have those who have made valuable contributions noted in the AUTHORS file. But there are people who have made minor contributions, like fixing typos, updating the links and such, to examples and README.md (which is effectively a part of documentation, and documentation is a part of the software, according to the MIT license). And however small their contributions may be, these are still contributions and it is fair to add those people to the AUTHORS file.
Additionally, the process of updating this file is now automated.
Changes:
update-authors.js
tool that traverses commit history usinggit log
and creates authors list..mailmap
file with proper names and emails of active collaborators. This file is automatically parsed by Git so thatgit log --format='%aN <%aE>'
won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only.tools/update-authors.js
.