Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,meta: make AUTHORS reflect all the contributors #88

Closed
wants to merge 8 commits into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 26, 2017

Right now we only have those who have made valuable contributions noted in the AUTHORS file. But there are people who have made minor contributions, like fixing typos, updating the links and such, to examples and README.md (which is effectively a part of documentation, and documentation is a part of the software, according to the MIT license). And however small their contributions may be, these are still contributions and it is fair to add those people to the AUTHORS file.

Additionally, the process of updating this file is now automated.

Changes:

  • Add new update-authors.js tool that traverses commit history using git log and creates authors list.
  • Decouple common functions into a module shared between tools.
  • Add .mailmap file with proper names and emails of active collaborators. This file is automatically parsed by Git so that git log --format='%aN <%aE>' won't show duplicate entries in case something was committed with misconfigured Git. E.g., without this file @tshemsedinov appears twice in the list, as Timur Shemsedinov and as tshemsedinov, but with mailmap applied Git automatically coalesces these entries to use the full name only.
  • Update the list using tools/update-authors.js.

* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file with proper names and emails of active
  collaborators.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.
AUTHORS Outdated
@@ -1,3 +1,6 @@
Timur Shemsedinov <timur.shemsedinov@gmail.com>
Dimon Durak <Dimon Durak>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimon-durak can you please provide your real name and email if you want to be included to the list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dmitry Borisov
dimon.durak@gmail.com

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added an entry for you in .mailmap and regenerated the list of contributors.

AUTHORS Outdated
Alexey Orlenko <eaglexrlnk@gmail.com>
Mykola Bilochub <nbelochub@gmail.com>
Vlad <Dzyubavlad@gmail.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DzyubSpirit please check if you email is correct here. And how would you prefer your full name to be spelled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Email is correct and I prefer to be Dzyuba WhatIsLove.

Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DzyubSpirit I think we prefer real names unless you have strong reasons to not be called Vlad Dzyuba. I was asking about the correct spelling of your last name, actually :)
What about email, maybe I should have been more explicit too: the question is whether it should be written with a capital letter or I can lowercase it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aqrln, okey. Right spelling of my last name is Dziuba. Let it be this way. My email case does not matter, so you can do what it is needed with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DzyubSpirit done.

* Don't use a Set together with an array, O(n^2) instead of O(n*log(n))
  is fine for such tool but the code is shorter.
* Use a regular for-of loop instead of reduce.
New commit message for 8915cd7:

tools: generate authors list automatically

* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case) and proper names and emails for
  two contributors who committed with invalid ones.
@aqrln
Copy link
Member Author

aqrln commented Mar 2, 2017

ping @belochub @tshemsedinov

Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqrln
Copy link
Member Author

aqrln commented Mar 6, 2017

@tshemsedinov ping

aqrln added a commit that referenced this pull request Mar 13, 2017
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case) and proper names and emails for
  two contributors who committed with invalid ones should be placed
  there.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
aqrln added a commit that referenced this pull request Mar 13, 2017
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
@aqrln
Copy link
Member Author

aqrln commented Mar 13, 2017

It's been a while and I suppose there are no objections. Landed in ebf9e2d, bf40c83 and 73d2533.

@aqrln aqrln closed this Mar 13, 2017
@aqrln aqrln deleted the generate-authors branch March 13, 2017 16:53
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
@aqrln aqrln mentioned this pull request Mar 13, 2017
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
aqrln added a commit that referenced this pull request Mar 13, 2017
aqrln added a commit that referenced this pull request Apr 2, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
aqrln added a commit that referenced this pull request Apr 2, 2017
aqrln added a commit that referenced this pull request Apr 2, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

Backport-of: #88
aqrln added a commit that referenced this pull request Apr 2, 2017
aqrln added a commit that referenced this pull request Apr 2, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 2, 2017
Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 2, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 2, 2017
Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 3, 2017
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln added a commit that referenced this pull request Apr 3, 2017
Backport-of: #88
PR-URL: #117
Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: #88
belochub pushed a commit that referenced this pull request Jan 22, 2018
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
belochub pushed a commit that referenced this pull request Jan 22, 2018
belochub pushed a commit that referenced this pull request Jan 22, 2018
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: #88
belochub pushed a commit that referenced this pull request Jan 22, 2018
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: #88
belochub pushed a commit that referenced this pull request Jan 22, 2018
@belochub belochub mentioned this pull request Jan 22, 2018
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
* Add new `update-authors.js` tool that traverses commit history using
  `git log` and creates authors list.

* Decouple common functions into a module shared between tools.

* Add `.mailmap` file.  This file is automatically parsed by Git so that
  `git log --format='%aN <%aE>'` won't show duplicate entries in case
  something was committed with misconfigured Git.  E.g., without this
  file @tshemsedinov appears twice in the list, as Timur Shemsedinov
  and as tshemsedinov, but with mailmap applied Git automatically
  coalesces these entries to use the full name only.  This file now
  includes the active collaborators (@tshemsedinov for a reason and
  @aqrln and @belochub just in case), proper names and emails of
  contributors who committed with invalid ones should be placed here.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
* Add all the contributors using `tools/update-authors.js`.
* Sort the mail map alphabetically.

PR-URL: metarhia/jstp#88
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants