Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fail CI if native addon build fails #65

Closed
wants to merge 1 commit into from
Closed

build: fail CI if native addon build fails #65

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 10, 2017

Fixes: #63

belochub
belochub approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aqrln added a commit that referenced this pull request Feb 10, 2017
@aqrln
build: fail CI if native addon build fails
58355f3 
Fixes: #63
PR-URL: #65
@aqrln
Copy link
Member Author

aqrln commented Feb 10, 2017

Landed in 58355f3.

@aqrln aqrln closed this Feb 10, 2017
@aqrln aqrln deleted the strict-ci branch February 10, 2017 14:43
@aqrln aqrln added the build label Feb 19, 2017
aqrln added a commit that referenced this pull request Feb 20, 2017
@aqrln
build: fail CI if native addon build fails
886eda3 
Fixes: #63
PR-URL: #65
@aqrln aqrln mentioned this pull request Feb 20, 2017
Merged
aqrln added a commit that referenced this pull request Feb 20, 2017
@aqrln
build: fail CI if native addon build fails
756becc 
Fixes: #63
PR-URL: #65
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
build: fail CI if native addon build fails
813fc1f 
Fixes: #63
PR-URL: #65
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
build: fail CI if native addon build fails
2c990a1 
Fixes: #63
PR-URL: #65
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
belochub pushed a commit that referenced this pull request Feb 8, 2018
@nechaido @belochub
build: fail CI if native addon build fails
2bbc015 
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
@nechaido nechaido mentioned this pull request Feb 8, 2018
Closed
belochub pushed a commit that referenced this pull request Feb 9, 2018
@nechaido @belochub
build: fail CI if native addon build fails
ad3551c 
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
belochub pushed a commit that referenced this pull request Feb 9, 2018
@nechaido @belochub
build: fail CI if native addon build fails
36c0636 
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
PR-URL: #325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jun 9, 2018
@nechaido @belochub
build: fail CI if native addon build fails
eed02ba 
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
PR-URL: #325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
build: fail CI if native addon build fails
868c343 
Fixes: metarhia/jstp#63
PR-URL: metarhia/jstp#65
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@nechaido @belochub
build: fail CI if native addon build fails
44dd197 
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
build: fail CI if native addon build fails
1c5dd37 
Fixes: metarhia/jstp#63
PR-URL: metarhia/jstp#65
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@nechaido @belochub
build: fail CI if native addon build fails
305f9a2 
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
@aqrln @belochub
build: fail CI if native addon build fails
4e798bc 
Fixes: metarhia/jstp#63
PR-URL: metarhia/jstp#65
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
@nechaido @belochub
build: fail CI if native addon build fails
c225da6 
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belochub belochub belochub approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqrln @belochub