Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fail CI if native addon build fails #325

Closed
wants to merge 1 commit into from
Closed

Conversation

nechaido
Copy link
Member

@nechaido nechaido commented Feb 8, 2018

This is an additional patch to that made in #65 that enables failing for CI systems other than Travis.

Refs: #63

This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
belochub pushed a commit that referenced this pull request Feb 9, 2018
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
PR-URL: #325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub
Copy link
Member

belochub commented Feb 9, 2018

Landed in 36c0636.

@belochub belochub closed this Feb 9, 2018
@belochub belochub deleted the stricter-ci branch February 9, 2018 17:18
belochub pushed a commit that referenced this pull request Jun 9, 2018
This is an additional patch to that made in
#65
that enables failing for CI systems other than
Travis.

Refs: #63
PR-URL: #325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub belochub mentioned this pull request Jun 9, 2018
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
This is an additional patch to that made in
metarhia/jstp#65
that enables failing for CI systems other than
Travis.

Refs: metarhia/jstp#63
PR-URL: metarhia/jstp#325
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants