Skip to content

Commit

Permalink
deps: update tap
Browse files Browse the repository at this point in the history
Also remove workaround for previous versions.

PR-URL: #227
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
  • Loading branch information
nechaido committed Jun 22, 2017
1 parent 54954b7 commit ae2717c
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 86 deletions.
92 changes: 15 additions & 77 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,10 @@
"babel-preset-es2015": "^6.24.1",
"eslint": "^3.19.0",
"eslint-plugin-import": "^2.3.0",
"lodash.isequal": "^4.5.0",
"remark-cli": "^3.0.1",
"remark-lint": "^6.0.0",
"remark-validate-links": "^6.0.0",
"tap": "^10.3.3",
"tap": "^10.5.1",
"webpack": "^2.6.1"
},
"scripts": {
Expand Down
9 changes: 2 additions & 7 deletions test/todo/json5.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const fs = require('fs');
const path = require('path');
const tap = require('tap');
const deepEqual = require('lodash.isequal');
const jstp = require('../..');

const supportedByUs = {
Expand Down Expand Up @@ -59,16 +58,12 @@ testCases.forEach((testCase) => {
test.strictSame(jstp.parse(file), JSON.parse(file));
break;
case '.json5':
// Currently tap.strictSame() doesn't work well with NaNs.
// That is why we check if lodash.isequal returns true.
test.assert(deepEqual(jstp.parse(file), extendedEval(file)));
test.strictSame(jstp.parse(file), extendedEval(file));
break;
case '.js': {
const supportedTests = supportedByUs[testCase.name];
if (supportedTests && supportedTests.includes(testName)) {
// Currently tap.strictSame() doesn't work well with NaNs.
// That is why we check if lodash.isequal returns true.
test.assert(deepEqual(jstp.parse(file), extendedEval(file)));
test.strictSame(jstp.parse(file), extendedEval(file));
} else {
test.throws(() => jstp.parse(file));
}
Expand Down

0 comments on commit ae2717c

Please sign in to comment.