Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events should support multiple arguments #162

Closed
aqrln opened this issue May 11, 2017 · 1 comment
Closed

Events should support multiple arguments #162

aqrln opened this issue May 11, 2017 · 1 comment
Labels
connection feature-request protocol
Milestone
1.0.0

Comments

@aqrln
Copy link
Member

aqrln commented May 11, 2017

See #134 for the background.
@aqrln aqrln added this to the 1.0.0 milestone May 11, 2017
@aqrln
Copy link
Member Author

aqrln commented May 11, 2017

As @lundibundi has noted,

it'll not only be similar to EventEmitter but also to call

And that's the key point. Even though I don't find this feature much useful, neither I see any harm in implementing it, so let's do that to be consistent.

lundibundi added a commit that referenced this issue May 28, 2017
@lundibundi
lib: change event signature
b33b825 
Changes event message signature to always send an array
of arbitrary arguments. This makes it work same way as
EventEmitter does and also makes its usage similar to
call action.

Fixes: #134
Fixes: #162
belochub pushed a commit that referenced this issue Jan 22, 2018
@lundibundi @belochub
lib: change event signature
2637db2 
Changes event message signature to always send an array
of arbitrary arguments. This makes it work same way as
EventEmitter does and also makes its usage similar to
call action.

PR-URL: #187
Fixes: #134
Fixes: #162
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this issue Jan 22, 2018
@lundibundi @belochub
lib: change event signature
b466497 
Changes event message signature to always send an array
of arbitrary arguments. This makes it work same way as
EventEmitter does and also makes its usage similar to
call action.

PR-URL: #187
Fixes: #134
Fixes: #162
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
@lundibundi
lib: change event signature
d5d93d9 
Changes event message signature to always send an array
of arbitrary arguments. This makes it work same way as
EventEmitter does and also makes its usage similar to
call action.

PR-URL: metarhia/jstp#187
Fixes: metarhia/jstp#134
Fixes: metarhia/jstp#162
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
@lundibundi
lib: change event signature
92cb487 
Changes event message signature to always send an array
of arbitrary arguments. This makes it work same way as
EventEmitter does and also makes its usage similar to
call action.

PR-URL: metarhia/jstp#187
Fixes: metarhia/jstp#134
Fixes: metarhia/jstp#162
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connection feature-request protocol
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@aqrln