-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server is crashing on client disconnect after the heartbeat packet #217
Comments
@aqrln, ping. |
@aqrln this error resurfaced again on node 8.4.0 on branch
|
belochub
pushed a commit
that referenced
this issue
Jan 22, 2018
Clear handshake timeout on successful handshake and start sending heartbeat messages on successful handshake handler instead of handshake timeout handler. Fixes: #217 Fixes: #283 PR-URL: #290 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub
pushed a commit
that referenced
this issue
Jan 22, 2018
Clear handshake timeout on successful handshake and start sending heartbeat messages on successful handshake handler instead of handshake timeout handler. Fixes: #217 Fixes: #283 PR-URL: #290 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This bug occurred with JSTP version 0.5.2.
It is also highly possible that this issue isn't still fixed on master, it needs investigation.
The error log:
@aqrln, may you check this out please?
The text was updated successfully, but these errors were encountered: