tcp: fix URL parsing in client creation #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
approved these changes
May 5, 2017
belochub
changed the title
belochub
added a commit
that referenced
this pull request
May 5, 2017
|
Landed in 8c72d3e. |
|
@belochub you have an extra Aside, didn't we agree upon adding the reviewed-by metadata? |
|
@aqrln, yes, you are right. Should I update the commit? |
|
@belochub yeah, sure. Force-push it before it's too late :) |
belochub
added a commit
that referenced
this pull request
May 5, 2017
PR-URL: #128 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
@belochub no worries, thanks! |
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #128 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #128 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#128 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#128 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.