Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to Visual Studio Code JSTP plugin #151

Closed
wants to merge 1 commit into from
Closed

Added link to Visual Studio Code JSTP plugin #151

wants to merge 1 commit into from

Conversation

a-gubskiy
Copy link

No description provided.

@aqrln
Copy link
Member

aqrln commented May 10, 2017

Thanks for the contribution! I'm not sure about the need for this plugin though. As far as I can see, it adds syntax highlighting for files with extensions like .jstp, .jsrs and stuff, but we decided to drop them and use just plain .js almost a year ago, and now we are directing towards making our data format fully compliant to the JSON5 specs, so .json5 will be used as the extension.

@a-gubskiy
Copy link
Author

It is very good that you moving in global standards direction! But in this case, you have very outdated documentations here - https://metarhia.github.io/JSTP/data-formats/ and old examples here - https://github.com/metarhia/JSTP/tree/master/examples/data-formats. It very confused me as developer which want to investigate your protocol.

@aqrln
Copy link
Member

aqrln commented May 10, 2017

@ernado-x yeah, the lack of up-to-date documentation is definitely an issue :) Even README is misleading in some points. It is one of our priorities too, right after writing decent tests and increasing the test coverage to an acceptable value, which we're working on right now. One may expect us to start writing docs and examples in a week or two.

@aqrln
Copy link
Member

aqrln commented May 10, 2017

/cc @metarhia/jstp-core

I'd want to hear some input from other collaborators about whether this is something that we want. I'd say no and go ahead saying thanks again and closing the PR, but maybe it's just me.

@aqrln
Copy link
Member

aqrln commented May 12, 2017

Closing the PR based on the conversation above and thumb-up votes. Please let me know if you'd like to contribute to the project in any other ways. Thanks!

@aqrln aqrln closed this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants