parser: rework error handling #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
reviewed
May 24, 2017
src/jsrs_parser.cc
Outdated
| @@ -273,7 +269,7 @@ Local<Value> ParseBool(Isolate* isolate, | |||
| *size = 5; | |||
| } else { | |||
| THROW_EXCEPTION(TypeError, "Invalid format: expected boolean"); | |||
| result = Undefined(isolate); | |||
| result = MaybeLocal<Value>(); | |||
There was a problem hiding this comment.
Isn't this the very same value that result was initialized with at line 263?
There was a problem hiding this comment.
Yeah, right, I will remove redundant assignments, thanks for catching that 😃
lundibundi
approved these changes
May 24, 2017
src/jsrs_parser.cc
Outdated
| return Undefined(isolate); | ||
| } | ||
| MaybeLocal<Value> result; | ||
| result = (kParseFunctions[type])(isolate, str + start_pos, end, &parsed_size); |
There was a problem hiding this comment.
Just a nit but maybe it's better to make it into one statement? =)
src/jsrs_parser.cc
Outdated
| return Undefined(isolate); | ||
| } | ||
| MaybeLocal<Value> t; | ||
| t = kParseFunctions[current_type](isolate, |
There was a problem hiding this comment.
Same as before, this one will event fit actually.
aqrln
approved these changes
May 24, 2017
|
Landed in |
Merged
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Avoid using TryCatch introduced in 29b3e197ae4c33d1b9057b57731b4c422de764f3 by using MaybeLocal instead. PR-URL: metarhia/jstp#178 Refs: metarhia/jstp#143 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Avoid using TryCatch introduced in 29b3e197ae4c33d1b9057b57731b4c422de764f3 by using MaybeLocal instead. PR-URL: metarhia/jstp#178 Refs: metarhia/jstp#143 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Avoid using TryCatch introduced in 29b3e197ae4c33d1b9057b57731b4c422de764f3 by using MaybeLocal instead. PR-URL: metarhia/jstp#178 Refs: metarhia/jstp#143 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using TryCatch introduced in
29b3e19 by using MaybeLocal instead.
Refs: #143