Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix extra spaces inside links in README.md #205

Closed
wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jun 2, 2017

Don't let the HTML parser convert the newlines into spaces that end up
being inside the links and getting highlighted by, basically, removing
those newlines. The code formatting is still there though, and the lines
are kept under 80 characters, it's just the style of the HTML code that
was changed.

Fixes: #204

@aqrln aqrln added the doc label Jun 2, 2017
README.md Outdated
/>
</a>
<a href="https://travis-ci.org/metarhia/jstp"><img
src="https://travis-ci.org/metarhia/JSTP.svg?branch=master"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tshemsedinov heads up, this is going to conflict with your PR. Whichever lands later will have to be rebased.

Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't let the HTML parser convert the newlines into spaces that end up
being inside the links and getting highlighted by, basically, removing
those newlines. The code formatting is still there though, and the lines
are kept under 80 characters, it's just the style of the HTML code that
was changed.

Fixes: #204
@aqrln aqrln force-pushed the obliterate-the-emptiness branch from b9832c7 to 823c293 Compare June 2, 2017 22:12
@aqrln
Copy link
Member Author

aqrln commented Jun 2, 2017

Rebased to resolve the conflict.

aqrln added a commit that referenced this pull request Jun 3, 2017
Don't let the HTML parser convert the newlines into spaces that end up
being inside the links and getting highlighted by, basically, removing
those newlines. The code formatting is still there though, and the lines
are kept under 80 characters, it's just the style of the HTML code that
was changed.

Fixes: #204
PR-URL: #205
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Timur Shemsedinov <timur.shemsedinov@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Jun 3, 2017

Landed in 8cc77d8.

@aqrln aqrln closed this Jun 3, 2017
@aqrln aqrln deleted the obliterate-the-emptiness branch June 3, 2017 01:04
belochub pushed a commit that referenced this pull request Jan 22, 2018
Don't let the HTML parser convert the newlines into spaces that end up
being inside the links and getting highlighted by, basically, removing
those newlines. The code formatting is still there though, and the lines
are kept under 80 characters, it's just the style of the HTML code that
was changed.

Fixes: #204
PR-URL: #205
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Timur Shemsedinov <timur.shemsedinov@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
Don't let the HTML parser convert the newlines into spaces that end up
being inside the links and getting highlighted by, basically, removing
those newlines. The code formatting is still there though, and the lines
are kept under 80 characters, it's just the style of the HTML code that
was changed.

Fixes: #204
PR-URL: #205
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Timur Shemsedinov <timur.shemsedinov@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants