parser: fix parsing of big integer values #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement additional function for parsing integer values which cannot be parsed using standard library functions. Refs: #175
|
@aqrln, ping. |
aqrln
approved these changes
Jun 6, 2017
src/jsrs_parser.cc
Outdated
| break; | ||
| } | ||
| current_digit_value = current_digit <= '9' ? current_digit - '0' : | ||
| current_digit - 'A' + 10; |
There was a problem hiding this comment.
I believe this should be indented with four spaces.
There was a problem hiding this comment.
@aqrln, cpplint didn't complain about it, so I left it like that.
What do you say about moving it to the right, right after the question sign?
|
Landed in 417ef60. |
2 tasks
Merged
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Implement additional function for parsing integer values which cannot be parsed using standard library functions. Refs: metarhia/jstp#175 PR-URL: metarhia/jstp#208 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Implement additional function for parsing integer values which cannot be parsed using standard library functions. Refs: metarhia/jstp#175 PR-URL: metarhia/jstp#208 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Implement additional function for parsing integer values which cannot be parsed using standard library functions. Refs: metarhia/jstp#175 PR-URL: metarhia/jstp#208 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement additional function for parsing integer values which
cannot be parsed using standard library functions.
Refs: #175