parser: parse Unicode escape sequences in keys #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@belochub can you please rebase it? I think removing the old |
belochub
force-pushed
the
parser-unicode-escapes
branch
from
b42cd4b
to
181161c
Compare
|
@belochub can you, please, rebase this PR on master? |
belochub
force-pushed
the
parser-unicode-escapes
branch
from
181161c
to
61f1efb
Compare
|
@aqrln, @lundibundi, ping. |
aqrln
reviewed
Jun 22, 2017
src/jsrs_parser.cc
Outdated
|
|
||
| if (isxdigit(str[0])) { | ||
| result = ReadHexNumber(str, 4, ok); | ||
| *size = 4; |
There was a problem hiding this comment.
Should it check whether *ok is true before changing *size?
src/jsrs_parser.cc
Outdated
| return 0xFFFD; | ||
| } | ||
| } | ||
| result = ReadHexNumber(str + 1, hex_size, ok); |
There was a problem hiding this comment.
It should check whether result is a valid code point (i.e., something like \u{1234123412341234} must be a syntax error).
There was a problem hiding this comment.
Yeah, I looked into it and decided to reimplement ReadHexNumber overall, because it has some other problems.
belochub
force-pushed
the
parser-unicode-escapes
branch
from
d6c59bb
to
0a36841
Compare
belochub
force-pushed
the
parser-unicode-escapes
branch
from
0a36841
to
58bb604
Compare
|
@aqrln, I've updated |
aqrln
approved these changes
Jun 26, 2017
aqrln
pushed a commit
that referenced
this pull request
Jun 26, 2017
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: #219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
Landed in bef3572. |
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: #219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: #219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: metarhia/jstp#219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: metarhia/jstp#219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
* Implement surrogate Unicode pairs parsing. * Parse Unicode escape sequences in objects. * Rework ReadHexNumber function. * Improve key parsing performance by avoiding copying when possible. PR-URL: metarhia/jstp#219 Refs: https://github.com/metarhia/jstp/issues/152 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add support for Unicode surrogate pairs and improve key parsing performance by avoiding copying when possible.
Refs: https://github.com/metarhia/jstp/issues/152