parser: parse noctal number literals #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nechaido
reviewed
Jun 14, 2017
| } | ||
|
|
||
| if (!int32_overflow) { | ||
| result *= 10; |
There was a problem hiding this comment.
No, because then it will be octal number parsing.
aqrln
approved these changes
Jun 15, 2017
aqrln
pushed a commit
that referenced
this pull request
Jun 15, 2017
Refs: #175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: #221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
Landed in 726c8d8. |
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
Refs: #175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: #221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
that referenced
this pull request
Jan 22, 2018
Refs: #175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: #221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Refs: metarhia/jstp#175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: metarhia/jstp#221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Refs: metarhia/jstp#175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: metarhia/jstp#221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
added a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Refs: metarhia/jstp#175 Refs: https://github.com/metarhia/jstp/issues/152 PR-URL: metarhia/jstp#221 Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #175
Refs: https://github.com/metarhia/jstp/issues/152