Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update deps and regenerate package-lock.json #225

Closed
wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jun 19, 2017

Using the current package-lock.json (that was generated using
npm@5.0.0 and then amended a couple of times with newer npm versions),
npm generates a dependency tree that shows lots of errors in the npm list output. This commit regenerates the package tree with the latest
npm version in order to resolve these problems.

@aqrln aqrln added the deps label Jun 19, 2017
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Using the current `package-lock.json` (that was generated using
npm@5.0.0 and then amended a couple of times with newer npm versions),
npm generates a dependency tree that shows lots of errors in the `npm
list` output. This commit regenerates the package tree with the latest
npm version in order to resolve these problems.
@aqrln aqrln changed the title deps: regenerate broken package-lock.json deps: update deps and regenerate package-lock.json Jun 21, 2017
@aqrln
Copy link
Member Author

aqrln commented Jun 21, 2017

Rebased to incorporate new package from master. Additionally, since I regenerated the package-lock using rm -r node_modules package-lock.json && npm i, many dependency have been bumped, so I renamed both the commit and PR.

aqrln added a commit that referenced this pull request Jun 22, 2017
Using the current `package-lock.json` (that was generated using
npm@5.0.0 and then amended a couple of times with newer npm versions),
npm generates a dependency tree that shows lots of errors in the `npm
list` output. This commit regenerates the package tree with the latest
npm version in order to resolve these problems.

PR-URL: #225
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Jun 22, 2017

Landed in 54954b7.

@aqrln aqrln closed this Jun 22, 2017
@aqrln aqrln deleted the fix-broken-tree branch June 22, 2017 11:22
belochub pushed a commit that referenced this pull request Jan 22, 2018
Using the current `package-lock.json` (that was generated using
npm@5.0.0 and then amended a couple of times with newer npm versions),
npm generates a dependency tree that shows lots of errors in the `npm
list` output. This commit regenerates the package tree with the latest
npm version in order to resolve these problems.

PR-URL: #225
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
Using the current `package-lock.json` (that was generated using
npm@5.0.0 and then amended a couple of times with newer npm versions),
npm generates a dependency tree that shows lots of errors in the `npm
list` output. This commit regenerates the package tree with the latest
npm version in order to resolve these problems.

PR-URL: #225
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants