test: add tests for number parsing #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nechaido
changed the title
aqrln
approved these changes
Jun 26, 2017
lundibundi
approved these changes
Jun 27, 2017
|
|
||
| module.exports = [ | ||
| { | ||
| name: 'binary number starting with b', |
There was a problem hiding this comment.
I'd have named it like "binary number declared using 0b" as it's not really starting with b, but that's left to your discretion and I'm fine either way. (same in other places)
|
|
||
| module.exports = [ | ||
| { | ||
| name: 'object with numeric literals', |
There was a problem hiding this comment.
Maybe numeric keys will be better?
There was a problem hiding this comment.
@lundibundi, saying "numeric keys" is incorrect, it should be "numeric literals as keys".
Also, you've left this comment in the wrong PR, this change is from #237.
nechaido
force-pushed
the
add-deserialization-tests
branch
2 times, most recently
from
b13c8cf
to
bb5ac65
Compare
belochub
reviewed
Jun 27, 2017
| { | ||
| name: 'binary number starting with 0b', | ||
| value: 42, | ||
| serialized: '0b101010' |
There was a problem hiding this comment.
This shouldn't be in a folder named "json5" because JSON5 doesn't allow these binary number literals.
belochub
reviewed
Jun 27, 2017
| { | ||
| name: 'octal number starting with 0o', | ||
| value: 42, | ||
| serialized: '0o52' |
There was a problem hiding this comment.
Same goes for these octal number literals.
nechaido
force-pushed
the
add-deserialization-tests
branch
from
bb5ac65
to
e155cf5
Compare
|
@belochub ping. |
|
I am waiting for #237 to land and this PR's rebase afterwards. |
aqrln
approved these changes
Jul 7, 2017
aqrln
pushed a commit
that referenced
this pull request
Jul 7, 2017
PR-URL: #241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
PR-URL: metarhia/jstp#241 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #237.
Refs: #239.