lib: rewrite i-face introspection without promises #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
changed the title
belochub
reviewed
Jun 28, 2017
lib/transport-common.js
Outdated
| let errored = false; | ||
| const len = interfaces.length; | ||
| let cnt = 0; | ||
| interfaces.map(name => connection.inspectInterface(name, |
There was a problem hiding this comment.
What's the point of using a map method here, if the result is being ignored in the end?
Maybe replace it with forEach?
belochub
reviewed
Jun 28, 2017
lib/transport-common.js
Outdated
| reject(error); | ||
| } else { | ||
| resolve(proxy); | ||
| const proxies = {}; |
There was a problem hiding this comment.
This object should be created with Object.create(null) like it was done before this patch.
There was a problem hiding this comment.
@belochub yes, it's better, thanks
tshemsedinov
force-pushed
the
use-callbacks-luke
branch
2 times, most recently
from
67639cb
to
3d9e87c
Compare
|
Name and commit message of this PR exceed the 50 character limit, it should be renamed. |
belochub
reviewed
Jul 6, 2017
lib/transport-common.js
Outdated
| const proxies = Object.create(null); | ||
| let errored = false; | ||
| const len = interfaces.length; | ||
| let cnt = 0; |
There was a problem hiding this comment.
In my opinion, it is better to rename this variable to full name (count) to avoid possible misunderstanding.
lundibundi
approved these changes
Jul 7, 2017
tshemsedinov
force-pushed
the
use-callbacks-luke
branch
from
3d9e87c
to
076bea3
Compare
|
@belochub agree, fixed, who will merge? |
tshemsedinov
force-pushed
the
use-callbacks-luke
branch
from
076bea3
to
757e00e
Compare
belochub
changed the title
belochub
pushed a commit
that referenced
this pull request
Jul 7, 2017
PR-URL: #245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in 43c61e7. |
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #245 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.