Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add handling of EAGAIN error on connection #281

Closed
wants to merge 1 commit into from
Closed

lib: add handling of EAGAIN error on connection #281

wants to merge 1 commit into from

Conversation

belochub
Copy link
Member

This fixes the connection error in benchmark reported by @lundibundi in #253 (review).

@belochub belochub requested a review from lundibundi July 29, 2017 22:25
nechaido
nechaido approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@nechaido nechaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lundibundi
lundibundi approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

belochub added a commit that referenced this pull request Jul 31, 2017
@belochub
lib: add handling of EAGAIN error on connection
d5b6eaf 
PR-URL: #281
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@belochub
Copy link
Member Author

Landed in d5b6eaf.

@belochub belochub closed this Jul 31, 2017
@belochub belochub deleted the eagain-fix branch July 31, 2017 23:38
belochub added a commit that referenced this pull request Aug 3, 2017
@belochub
lib: fix multiple calls of callback in connect
423ec82 
This fixes bug introduced in #281.
@belochub belochub mentioned this pull request Aug 3, 2017
Closed
belochub added a commit that referenced this pull request Aug 4, 2017
@belochub
lib: fix multiple calls of callback in connect
c563b4c 
This fixes bug introduced in #281.

PR-URL: #293
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub added a commit that referenced this pull request Jan 22, 2018
@belochub
lib: add handling of EAGAIN error on connection
a2f6bb3 
PR-URL: #281
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub added a commit that referenced this pull request Jan 22, 2018
@belochub
lib: fix multiple calls of callback in connect
23694a6 
This fixes bug introduced in #281.

PR-URL: #293
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub added a commit that referenced this pull request Jan 22, 2018
@belochub
lib: add handling of EAGAIN error on connection
6172cd6 
PR-URL: #281
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub added a commit that referenced this pull request Jan 22, 2018
@belochub
lib: fix multiple calls of callback in connect
bcb42df 
This fixes bug introduced in #281.

PR-URL: #293
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nechaido nechaido nechaido approved these changes

@lundibundi lundibundi lundibundi approved these changes

@aqrln aqrln aqrln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@belochub @aqrln @lundibundi @nechaido