lint,deps: move ESLint config to a separate package #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies.
aqrln
changed the title
|
Failures (https://ci.appveyor.com/project/metarhia/jstp/build/140, https://ci.appveyor.com/project/metarhia/jstp/build/141) on Windows due to unsuccessful installation of |
|
Also, how about converting YAML to JSON in ESLint configs? I've done that in a number of other repos, and JSON looks pretty good with small configs, while being kinda more native than YAML in JS ecosystem. |
nechaido
approved these changes
Sep 8, 2017
I will not be against it now that the config is small. |
|
@nechaido @lundibundi updated, PTAL |
lundibundi
approved these changes
Sep 8, 2017
nechaido
approved these changes
Sep 8, 2017
belochub
approved these changes
Sep 8, 2017
aqrln
added a commit
that referenced
this pull request
Sep 8, 2017
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: #302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in 79154c9. |
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: #302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: #302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: metarhia/jstp#302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: metarhia/jstp#302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
Move ESLint configuration to a separate package (`eslint-config-metarhia`). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies. PR-URL: metarhia/jstp#302 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ESLint configuration to a separate package
(
eslint-config-metarhia). Also, bump ESLint to 4.6.1 (from 4.6.0)because that's what's specified in that package's peerDependencies.