Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependencies #308

Closed
wants to merge 1 commit into from
Closed

deps: update dependencies #308

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 27, 2017

/cc @nechaido do review that yargs update doesn't break anything.

@aqrln aqrln added the deps label Nov 27, 2017
@aqrln
Copy link
Member Author

aqrln commented Nov 27, 2017

Also, there's a pending update to the latest version of eslint-config-metarhia, but there are some stylistic changes that must be applied, and for some reason, tests are failing for me when I do that, so I guess I'll do that in a separate PR.

@nechaido
Copy link
Member

nechaido commented Dec 8, 2017

@aqrln could you please update this PR?

@belochub belochub changed the title deps: update devDependencies deps: update dependencies Jan 21, 2018
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, we can probably remove .help() from files in benchmark/distributed due to changes in yargs yargs changelog.

@belochub
Copy link
Member

@lundibundi, I think, we can do this in another PR.

belochub pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #308
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
@belochub
Copy link
Member

Landed in 65e502c.

@belochub belochub closed this Jan 22, 2018
belochub pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #308
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #308
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
@belochub belochub deleted the update-deps branch January 30, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants