JSTP 0.6.3 proposal #39

aqrln · 2017-01-31T21:11:08Z

Version 0.6.3

Update karma-webpack.
Enable native addon build on Windows (falling back to JavaScript implementation if the toolset is not installed).
Internal changes.

* Enable build on Windows using the native extensions if the build succeeded or falling back to JavaScript implementation otherwise. Spawn node-gyp under shell so that $PATH resolves correctly on Windows. * Remove check for Node.js versions < 4.0 since Node.js 6.0 is now the oldest supported version.

This commit adds explicit type casts to resolve compiler warnings about possible data loss.

Rename Object Serialization example from `person.jsrs` into `person.js` and add a missing Record Serialization example under that name.

The last column of the implementations table had been removed before but not in the columns definition row. GitHub's markdown parser has been able to parse it so it went unnoticed however the parsed used by docs generator inserts an empty column in such case.

Remove `const server = this;` lines in `lib/server.js` which were left from times when arrow functions were not used.

Remove the unnecessary "All rights reserved" phrase since the last country which laws used to required it got rid of it in 2000 and it has meant nothing throughout the rest of the world since very long time ago.

* Replace license text with references to the LICENSE files. * Update years.

* Split `jsrs-impl.cc` into separate modules. * Make some refactoring. * Rename the native addon to `jstp` since there already is a function that is not a part of JSRS. * Fix `binding.gyp`: make `cflags` not ignored on macOS (as it appeared they used to be) and do not use `-O3` in Debug configuration. * Use a macro to throw V8 exceptions to avoid boilerplate code. PR-URL: #36

* Use `cflags_cc` instead of `cflags`. * By default `node-gyp` uses `-std=gnu++0x`. This commit modifies `cflags_cc` to use `-std=c++11`. PR-URL: #37

* Update `karma-webpack`. * Enable native addon build on Windows (falling back to JavaScript implementation if the toolset is not installed). * Internal changes. PR-URL: #39

belochub

LGTM

tshemsedinov

Comments are not critical

tshemsedinov · 2017-01-31T21:25:03Z

build-native.js

@@ -27,5 +19,9 @@ nodeGyp.on('exit', (code) => {
  if (errorLines.length > 0) {
    fs.writeFileSync('builderror.log', errorLines.join('\n'));
  }
-  process.exit(code);
+  if (code !== 0) {


if (code)

tshemsedinov · 2017-01-31T21:32:33Z

lib/record-serialization.js


 try {
-  jsrsNative = require('../build/Release/jsrs');
+  jstpNative = require('../build/Release/jstp');


To avoid enclosure try, better create safe require

const safeRequire = name => { try { return require(name); } catch (e) { return e; } };

* Handle the situation when a compiler cannot be spawned and `exit` event is not fired. * Make `0` a named constant. PR-URL: #40

Get rid of nested try-catch statements. Decouple `safeRequire` function that can be used later. PR-URL: #41

* Update `karma-webpack`. * Enable native addon build on Windows (falling back to JavaScript implementation if the toolset is not installed). * Internal changes. PR-URL: #39

aqrln · 2017-01-31T22:49:02Z

@tshemsedinov @belochub commits that resolve the nits mentioned before are added to the release too.

belochub · 2017-01-31T22:56:41Z

@aqrln, yes, I've already reviewed corresponding PRs, and including them in this PR seems fine to me.

aqrln · 2017-01-31T22:57:12Z

@belochub waiting for CI to complete ;)

aqrln · 2017-01-31T23:04:01Z

@tshemsedinov @belochub version 0.6.3 successfully published to NPM 🎉

aqrln added 16 commits January 31, 2017 22:57

test: refactor RawServerMock

1c493df

lib,ws,tcp: decouple ensureClientConnected(client)

c8e6cb4

deps: update karma-webpack

0a6a7ed

lint: increase source file limit on BitHound

0cbfa90

parser: fix compiler warnings

97c4946

This commit adds explicit type casts to resolve compiler warnings about possible data loss.

examples: fix inconsistency with specification

3e3b455

Rename Object Serialization example from `person.jsrs` into `person.js` and add a missing Record Serialization example under that name.

doc: fix a table in index.md

3a8d47a

lint: ignore Object Serialization examples

c4c82dd

lib: remove obsolete this copying

2d3d075

Remove `const server = this;` lines in `lib/server.js` which were left from times when arrow functions were not used.

dist: update LICENSE

1c1a7e1

Remove the unnecessary "All rights reserved" phrase since the last country which laws used to required it got rid of it in 2000 and it has meant nothing throughout the rest of the world since very long time ago.

src: simplify and update license boilerplates

f6640a2

* Replace license text with references to the LICENSE files. * Update years.

test: add Node.js 7.4 to .travis.yml

b26abd2

build: compile in ISO C++11 mode

a444b34

* Use `cflags_cc` instead of `cflags`. * By default `node-gyp` uses `-std=gnu++0x`. This commit modifies `cflags_cc` to use `-std=c++11`. PR-URL: #37

aqrln added the compatibility label Jan 31, 2017

aqrln self-assigned this Jan 31, 2017

aqrln added release security labels Jan 31, 2017

aqrln requested review from tshemsedinov and belochub January 31, 2017 21:17

aqrln force-pushed the v0.6-staging branch from 06f126b to 909a5a2 Compare January 31, 2017 21:19

aqrln added a commit that referenced this pull request Jan 31, 2017

Version 0.6.3

909a5a2

* Update `karma-webpack`. * Enable native addon build on Windows (falling back to JavaScript implementation if the toolset is not installed). * Internal changes. PR-URL: #39

belochub approved these changes Jan 31, 2017

View reviewed changes

tshemsedinov approved these changes Jan 31, 2017

View reviewed changes

aqrln added 3 commits February 1, 2017 00:45

build: improve error handling

d2459a8

* Handle the situation when a compiler cannot be spawned and `exit` event is not fired. * Make `0` a named constant. PR-URL: #40

lib: refactor record-serialization.js

2e2c8cc

Get rid of nested try-catch statements. Decouple `safeRequire` function that can be used later. PR-URL: #41

Version 0.6.3

9c538ec

* Update `karma-webpack`. * Enable native addon build on Windows (falling back to JavaScript implementation if the toolset is not installed). * Internal changes. PR-URL: #39

aqrln force-pushed the v0.6-staging branch from 909a5a2 to 9c538ec Compare January 31, 2017 22:45

aqrln merged commit 9c538ec into v0.6 Jan 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JSTP 0.6.3 proposal #39

JSTP 0.6.3 proposal #39

aqrln commented Jan 31, 2017

belochub left a comment

tshemsedinov left a comment

tshemsedinov Jan 31, 2017

aqrln Jan 31, 2017

tshemsedinov Jan 31, 2017

aqrln Jan 31, 2017

aqrln commented Jan 31, 2017

belochub commented Jan 31, 2017 •

edited

Loading

aqrln commented Jan 31, 2017

aqrln commented Jan 31, 2017

JSTP 0.6.3 proposal #39

JSTP 0.6.3 proposal #39

Conversation

aqrln commented Jan 31, 2017

belochub left a comment

Choose a reason for hiding this comment

tshemsedinov left a comment

Choose a reason for hiding this comment

tshemsedinov Jan 31, 2017

Choose a reason for hiding this comment

aqrln Jan 31, 2017

Choose a reason for hiding this comment

tshemsedinov Jan 31, 2017

Choose a reason for hiding this comment

aqrln Jan 31, 2017

Choose a reason for hiding this comment

aqrln commented Jan 31, 2017

belochub commented Jan 31, 2017 • edited Loading

aqrln commented Jan 31, 2017

aqrln commented Jan 31, 2017

belochub commented Jan 31, 2017 •

edited

Loading