connection: change style of a forward declaration #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
|
Landed in f6f0aba. |
aqrln
added a commit
that referenced
this pull request
Mar 3, 2017
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
PR-URL: #96
aqrln
added a commit
that referenced
this pull request
Mar 13, 2017
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
PR-URL: #96
Merged
aqrln
added a commit
that referenced
this pull request
Mar 13, 2017
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
PR-URL: #96
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
PR-URL: #96
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
ESLint complains that a variable is never reassigned if it is declared
like this:
let variable;
...
variable = value;
Because of this, we had a forward declaration in `connection.js` marked
with a directive for ESLint to ignore the line. This commit changes it
to assignment to null.
PR-URL: #96
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint complains that a variable is never reassigned if it is declared
like this:
Because of this, we had a forward declaration in
connection.jsmarkedwith a directive for ESLint to ignore the line. This commit changes it
to assignment to null.