parser: improve overall parser performance #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
approved these changes
Aug 25, 2018
src/node_bindings.cc
Outdated
| std::size_t length; | ||
|
|
||
| if (args[0]->IsString()) { | ||
| String::Utf8Value utf8str(args[0]); |
There was a problem hiding this comment.
Nit: I think str is also fine here.
aqrln
approved these changes
Aug 27, 2018
belochub
force-pushed
the
parser-optimization
branch
2 times, most recently
from
aa5258d to
fd12219
Compare
* Slightly improve string parsing performance. * Highly improve parsing performance for Buffers by avoiding toString conversion (leading to copying data). Refs: metarhia/jstp#254
belochub
force-pushed
the
parser-optimization
branch
from
fd12219 to
1ffcf07
Compare
belochub
added a commit
that referenced
this pull request
Aug 28, 2018
* Slightly improve string parsing performance. * Highly improve parsing performance for Buffers by avoiding toString conversion (leading to copying data). Refs: metarhia/jstp#254 PR-URL: #21 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
|
Landed in 450c67a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoiding toString conversion (leading to copying data).
Refs: metarhia/jstp#254