Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: arithmetic operators #11

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zpwebbear
Copy link

@zpwebbear zpwebbear commented Dec 3, 2024

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fix)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

I kept only one return from this function. Solution with
conditional check if the operator's length is 1 disable the ability
to provide addition, subtraction, multiplication and division
with multiple arguments (more than two).
@zpwebbear zpwebbear mentioned this pull request Dec 3, 2024
4 tasks
@zpwebbear
Copy link
Author

@tshemsedinov I've pushed fixes for linter errors. For some reason I forgot to run npm t on the previous commit. Currently all tests and linters are green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant