feat(Expressions): add boolean symbols #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
reviewed
Dec 5, 2024
lib/expressions.js
Outdated
| } | ||
|
|
||
| interpret() { | ||
| if (!(this.value in BooleanExpression.tokens)) { |
There was a problem hiding this comment.
I'd prefer to check it in constructor
lib/expressions.js
Outdated
Comment on lines
5
to
9
| class BooleanExpression { | ||
| static tokens = { | ||
| t: true, | ||
| nil: false, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| class BooleanExpression { | |
| static tokens = { | |
| t: true, | |
| nil: false, | |
| }; | |
| const BOOL = { | |
| t: true, | |
| nil: false, | |
| }; | |
| class BooleanExpression { |
|
@tshemsedinov I've provided changes that you've highlighted. The single question that I want to ask is about CHANGELOG. I don't know what to write in this file 😄 |
tshemsedinov
reviewed
Dec 9, 2024
lib/expressions.js
Outdated
| if (!(value in BOOL)) { | ||
| throw new Error(`Unknown boolean value: ${value}`); | ||
| } | ||
| this.value = value; |
There was a problem hiding this comment.
We can store value as javascript boolean type, receiving either js boolean or t/nil
lib/parser.js
Outdated
Comment on lines
37
to
43
| const expressionFactory = (token) => { | ||
| if (!isNaN(token)) return new NumberExpression(token); | ||
| if (token in BOOL) { | ||
| return new BooleanExpression(token); | ||
| } | ||
| return new VariableExpression(token); | ||
| }; |
There was a problem hiding this comment.
I'd prefer to have .type field in all Expressions instead of slow instanceof
Additionly type field was added to all Expression classes Refs: metarhia#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm t)npm run fix)