Fixed an error when creating a structure file #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an error when creating structure.sql file for a database, when it is necessary to create a relation for tables that refer to each other.
Fixed an error when creating structure.sql file for a database, when it is necessary to create a relation for tables that refer to each other. Fixed ussues Metasql metarhia#291
tshemsedinov
reviewed
Sep 5, 2024
| @@ -201,6 +206,7 @@ const createEntity = (model, name) => { | |||
| } | |||
| sql[sql.length - 1] = sql[sql.length - 1].slice(0, -1); | |||
| sql.push(');'); | |||
| if (delayedKeys[name]) idx.push(delayedKeys[name]); | |||
There was a problem hiding this comment.
Can:
const delayedKeyCurrent = delayedKeys[name];
if (delayedKeyCurrent) idx.push(delayedKeyCurrent);
tshemsedinov
reviewed
Sep 5, 2024
| @@ -183,7 +183,12 @@ const createEntity = (model, name) => { | |||
| const ref = model.entities.get(def.type); | |||
| if (!ref) throw new Error(`Unknown schema: ${def.type}`); | |||
| const refId = ref.kind === 'registry'; | |||
| idx.push(foreignKey(name, field, def, refId)); | |||
| const fKey = foreignKey(name, field, def, refId); | |||
| if (def.type in delayedKeys && def.type !== name) { | |||
There was a problem hiding this comment.
delayedKeys is an object with fields filled with nulls, so reading the property via [ key ] will not work. Therefore, I can change it to hasOwnProperty or Object.prototype.hasOwnProperty.call. Or suggest something else? Because hasOwnProperty is almost 100 times slower, although it is not critical here, but this is system code - that's why I used 'in'. Write what to put.
in dbms.js
for (const key of model.order) {
delayedKeys[key] = null;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error when creating structure.sql file for a database, when it is necessary to create a relation for tables that refer to each other.
Fixed ussues Metasql #291
npm t)npm run fmt)