Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Values in Collector #231

Merged
merged 16 commits into from
Dec 20, 2023
Merged

Default Values in Collector #231

merged 16 commits into from
Dec 20, 2023

Conversation

axbuglak
Copy link
Contributor

@axbuglak axbuglak commented Dec 11, 2023 •
edited
Loading

Implemented default values in Collector #221

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

@axbuglak axbuglak mentioned this pull request Dec 11, 2023
Open
Bespaliy
Bespaliy reviewed Dec 12, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
zoff4ick
zoff4ick reviewed Dec 12, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
zoff4ick
zoff4ick reviewed Dec 12, 2023
View reviewed changes
test/collector.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 12, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
zoff4ick
zoff4ick reviewed Dec 12, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
zoff4ick
zoff4ick reviewed Dec 12, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/collector.js Outdated Show resolved Hide resolved
metautil.d.ts Outdated Show resolved Hide resolved
metautil.d.ts Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 19, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 19, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 19, 2023
View reviewed changes
lib/collector.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Dec 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tshemsedinov tshemsedinov merged commit f5926f1 into metarhia:master Dec 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bespaliy Bespaliy Bespaliy left review comments

@zoff4ick zoff4ick zoff4ick left review comments

@tshemsedinov tshemsedinov tshemsedinov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axbuglak @tshemsedinov @zoff4ick @Bespaliy