Feature/gokit v0.5.0 support #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewhartstonge As far as I can tell from a brief look, the cyclic dependency is at its root due to the creation of the That interface should probably go in a separate file in the same folder where the |
|
GoKit potential upgrade is being covered here: #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed between starting this, there was a PR that moved middlewares into the handlers folder, which now causes a cyclic dependency.
Currently with this PR I've moved
middlewares.goback out in order to remove the cycle, hence integration tests break. I believe this was to make it easier for the end user by having everything inhandlers/?What are your thoughts on removing this cycle?