Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly map request body field by name #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chebykinn
Copy link

Hi, I've tried to fix issue #325, this PR should do it.

I've changed the field path to body_root if the current field is mapped by name, which allows setting RequestRootField in gengokit/http_transport.go, which is, in turn, checked in the template to select in which variable body will be deserialized.
This fixes the issue in my cases, although maybe it should probably be worth hiding this fix under some option, at least for a few releases to keep backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant