Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hash as "view commit" link #4

Closed
adamhalesworth opened this issue Apr 30, 2020 · 4 comments
Closed

Commit hash as "view commit" link #4

adamhalesworth opened this issue Apr 30, 2020 · 4 comments

Comments

@adamhalesworth
Copy link

adamhalesworth commented Apr 30, 2020

Hey,

Would it be possible to have an input that allows us to use the shortened commit hash i.e. dcb19ff as the link to the commit itself?

It could be in the format:

[`dcb19ff`](example.com) - Commit message

Quite happy to make a PR if you don't have time to work on this?

@metcalfc
Copy link
Owner

metcalfc commented Apr 30, 2020 via email

metcalfc added a commit that referenced this issue Apr 30, 2020
It seems useful to display the short hash and convey additional
info.
@metcalfc
Copy link
Owner

As I was thinking about it, I realized it was a two character change. So I just knocked it out really quick. You can find it here: https://github.com/metcalfc/changelog-generator/releases/tag/v0.3.0

Thanks for the suggestion. Hope you find the action useful.

@adamhalesworth
Copy link
Author

Hey, thanks for implementing this. Don't know if you noticed but the commit link had backticks in it so that the short commit hash would be monospace. No biggie though!

@metcalfc
Copy link
Owner

metcalfc commented May 1, 2020

Fixed in v0.3.2. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants