no commit hash url text

[Slluxx]

Releases have this text for me:

* [](http://github.com/../../../) - Update VERSION
* [](http://github.com/../../../) - Update buildRelease.yml
* [](http://github.com/../../../) - Update buildRelease.yml

The URL works and is complete but the text is missing, thus its displaying a line as:

• - Update VERSION

I am building a release like this (in case this has to do something with it):

    - name: Create Release
      run: |
        set -x
        assets=()
        for asset in ./*.zip; do
          assets+=("-a" "$asset")
        done
        hub release create "${assets[@]}" -d -m "Release v${{ steps.set-version.outputs.version }}
        
        ${{ steps.changelog.outputs.changelog }}" "v${{ steps.set-version.outputs.version }}"
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[metcalfc]

Thats odd. So the bit that does the real work here is a one liner in bash:

log=$(git log "${base_ref}...${head_ref}" \
  --pretty=format:"* [\`%h\`](http://github.com/${repo_url}/commit/%H) - %s" \
  --reverse)

My guess is that the way you're doing the notes is getting wrecked in the shell via expansions. There are backticks in the short hash link so those could be getting evaluated. I'm not sure if there is a better way to escape those in a shell.

Have you considered using a release specific action instead of hub in shell script? https://github.com/marketplace/actions/create-release seems reasonably aligned:

    - uses: ncipollo/release-action@v1
      with:
        artifacts: "./*zip"
        name: "Release v${{ steps.set-version.outputs.version }}"
        body: "${{ steps.changelog.outputs.changelog }}"
        tag: "v${{ steps.set-version.outputs.version }}"
        token: ${{ secrets.GITHUB_TOKEN }}

[Slluxx]

Allrighty, using release-action@v1 the body looks just like expected. I had a reason for using hub but i think that is obsolete so this solution is 100% better.

---

I do have 2 unrelated feature requests though:
Is it possible to display not just the commit title but also the description? like this:

• 357e49f - Added: Includes now dumps of all currently available Emuiibos
  And here the commit description. more explanation without cramming important sentences into the title.
  Preferably multi line, for some beautiful formatted text. maybe the commit description can have markdown styling so it shows here perfectly?
• 94a8cd6 - Changed: Update buildRelease.yml
• a4452bc - Changed: python setup action
  again with body text

And my other, more advanced request would be to use keywords to group commit messages.
See this example: https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md

Basically if a commit message starts with Added:, Removed:, Fixed: or Changed: it will group them together and display them like this (other if no prefix):

Added

• 357e49f - Added: Includes now dumps of all currently available Emuiibos

Changed

• 94a8cd6 - Changed: Update buildRelease.yml
• a4452bc - Changed: python setup action

Other

• 154c8b7 - Bumped Version to 2.1.0

Those 2 Features together would make this changelog-generator just absolutly perfect.

[Slluxx]

@metcalfc hey you havent replied in a while. i know my text would belong in a new issue but may you still take a look at my suggestion?

[metcalfc]

Hey Calvin, sorry for the late reply. I'm on an extended vacation and doing my best to stay off work related sites. What I set out for this action was to be the most simple, collect the commits since the last release, configure next to nothing, and don't require commits to be a format action in its category. I think those are good features. And there are a few similar actions that implement them like: Release Drafter · Actions · GitHub Marketplace <https://github.com/marketplace/actions/release-drafter> GitHub marketplace doesn't do a great job surfacing all the options and making it clear what the feature differences are. Maybe thats a good thing to add to the README. "This is the super simple changelog generator" I appreciate the feedback.

…

On Wed, Feb 17, 2021 at 7:57 AM Calvin ***@***.***> wrote: @metcalfc <https://github.com/metcalfc> hey you havent replied in a while. i know my text would belong in a new issue but may you still take a look at my suggestion? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHZNN25MUFRZB2ER3LBQLS7PROVANCNFSM4XLSXTKA> .

[Slluxx]

Sorry to disturb your vacation! Your action is great as is and i completely get the point of a simple one like this. Thanks for pointing me in another direction and i hope you have a few more great days ahead!

Cheers!