Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile.username vs profile.name #388

Closed
SachaG opened this issue May 16, 2015 · 5 comments
Closed

profile.username vs profile.name #388

SachaG opened this issue May 16, 2015 · 5 comments

Comments

@SachaG
Copy link

SachaG commented May 16, 2015

If I'm not mistaken, it seems like if someone logs in with username/password their username gets copied to profile.username, while if they use Twitter it gets copied to profile.name. Maybe it'd be better to harmonize both?

@splendido
Copy link
Member

Yeah, absolutely!
If this is actually what's happening, we need to fix it!
I'll have a look

@SachaG
Copy link
Author

SachaG commented May 19, 2015

I can also confirm that logging in via Facebook creates a profile.name field.

@splendido
Copy link
Member

I'd say this line is the one causing the profile.name to be set after facebook signup...

And this is the one for google, twitter, etc.

So we'd need to change this line to be:

options.profile.name = signupInfo.username;

but this would be somehow break retro compatibility?

@etmarch
Copy link

etmarch commented May 20, 2015

+1, as this makes integrating with a package like simple schema more of a hassle

@splendido
Copy link
Member

This won't be a retro-compatible change...
But since I don't think many people is using this, lets close an eye ;-)
v2 will be for something else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants