Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the login button link #265

Merged
merged 2 commits into from
Feb 2, 2015
Merged

Conversation

adrianmcli
Copy link
Contributor

I was having trouble with getting the nav button to redirect properly. I think this fixes it.

@splendido
Copy link
Member

Hei @adrianmc,
yeah the atNavButton at the moment works only if you do a AccountsTemplates.configureRoute('atSignIn') leaving the route's name unchanged (atSingIn).

The solution you're proposing might create some problem in case it gets to this line being executed.

I'd say a better solution would be something like this line:

Router.go(AccountsTemplates.getRouteName('signIn'));

But still this will work only if you configured the sign in route with `AccountsTemplates.configureRoute'

Could you please update the this PR?

@adrianmcli
Copy link
Contributor Author

I have updated it with your suggestion, thanks for the reply!

splendido added a commit that referenced this pull request Feb 2, 2015
fixed the login button link
@splendido splendido merged commit ed69f88 into meteor-useraccounts:master Feb 2, 2015
@splendido
Copy link
Member

Great, tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants