Skip to content

Update babel-compiler for Meteor 1.6.1 compatibility #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2018

Conversation

akanix42
Copy link
Contributor

Updates the babel-compiler package as required to support Meteor 1.6.1. Fixes #290.

@mwarren2
Copy link

mwarren2 commented Jan 26, 2018

@nathantreid Would you mind doing the same for vue-router2, which has babel-compiler@6.8.0? - Presumably you can do it in the same pull request.

Package.registerBuildPlugin({
name: 'vue-router',
use: [
'ecmascript@0.4.4',
'caching-compiler@1.0.5',
'babel-compiler@6.8.0',
],
sources: [
'plugin/plugin.js',
],
})

bash-3.2$ meteor update --release=1.6.1
=> Errors while initializing project:

While selecting package versions:
error: Conflict: Constraint babel-compiler@6.13.0 is not satisfied by babel-compiler 7.0.0.
Constraints on package "babel-compiler":

  • babel-compiler@~7.0.0 <- top level
  • babel-compiler@7.0.0 <- ecmascript 0.10.0
  • babel-compiler@7.0.0 <- standard-minifier-js 2.3.1
  • babel-compiler@7.0.0 <- minifier-js 2.3.1 <- standard-minifier-js 2.3.1
  • babel-compiler@6.13.0 <- akryum:vue-component 0.12.3
  • babel-compiler@6.8.0 <- akryum:vue-router2 0.1.1

Conflict: Constraint babel-compiler@6.8.0 is not satisfied by babel-compiler 7.0.0.
Constraints on package "babel-compiler":

  • babel-compiler@~7.0.0 <- top level
  • babel-compiler@7.0.0 <- ecmascript 0.10.0
  • babel-compiler@7.0.0 <- standard-minifier-js 2.3.1
  • babel-compiler@7.0.0 <- minifier-js 2.3.1 <- standard-minifier-js 2.3.1
  • babel-compiler@6.13.0 <- akryum:vue-component 0.12.3
  • babel-compiler@6.8.0 <- akryum:vue-router2 0.1.1

@akanix42
Copy link
Contributor Author

Added the update for vue-router2. I also have published versions of these packages that contain the fix (nathantreid:vue-component and nathantreid:vue-router2) that can be used until the akryum packages are updated.

@Akryum Akryum merged commit 34355bd into meteor-vue:master Jan 27, 2018
@mwarren2
Copy link

mwarren2 commented Jan 27, 2018

@nathantreid I see that this has been merged. Thanks very much for the work you did on this.

But while I can install your versions, the akryum ones still give exactly the same Babel messages, despite the merge.
Do you have any idea why?

@Akryum
Copy link
Collaborator

Akryum commented Jan 27, 2018

Didn't have time to publish anything (was shopping). 😸

@mwarren2
Copy link

Ah! Hadn't thought of that.
Hope you found everything you needed at the shops. Have a good weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants