forked from npm/fstream
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix treatment of long file paths in Windows
3e5d171 (from November 2011) introduced this code to fix treatment of long file paths in Windows. Then, one week later, this commit fixed long file paths directly in Node's `fs` library: nodejs/node-v0.x-archive@1f16a7b So, the code currently in fstream actually /breaks/ long file paths in Windows. This fixes it, but keeps an additional mysterious line introduced by that original commit that I don't understand. Fixes npm#30. Thanks to @sdarnell for identifying the problem.
- Loading branch information
Showing
2 changed files
with
2 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this line is trying to escape any question mark which would become invalid when converted to the UNC form. However, I think it should be removed as any escaping of this sort should be performed on the same place as the conversion to UNC.
I suspect it was a misguided hack to try to get things working, and IMO should not be done even in libuv.