Skip to content

Commit

Permalink
Only prepare instead of build the Cordova project for iOS
Browse files Browse the repository at this point in the history
Building the iOS app for release should be done from Xcode anyway, to
correctly code sign and submit to TestFlight or the App Store.

Because building would override `build-extras.xcconfig`, this would
remove a temporary workaround for #6492, which is now correctly applied
on both `meteor run` and `meteor build`.
martijnwalraven committed Mar 30, 2016
1 parent 9239a94 commit 88d43a0
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tools/cli/commands.js
Original file line number Diff line number Diff line change
@@ -966,8 +966,7 @@ ${Console.command("meteor build ../output")}`,
{ title: `building Cordova app for \
${cordova.displayNameForPlatform(platform)}` }, () => {
let buildOptions = { release: !options.debug };
cordovaProject.buildForPlatform(platform, buildOptions);


const buildPath = files.pathJoin(
projectContext.getProjectLocalDirectory('cordova-build'),
'platforms', platform);
@@ -977,6 +976,8 @@ ${cordova.displayNameForPlatform(platform)}` }, () => {
files.pathJoin(platformOutputPath, 'project'));

if (platform === 'ios') {
cordovaProject.prepareForPlatform(platform, buildOptions);

files.writeFile(
files.pathJoin(platformOutputPath, 'README'),
`This is an auto-generated XCode project for your iOS application.
@@ -985,6 +986,8 @@ Instructions for publishing your iOS app to App Store can be found at:
https://github.com/meteor/meteor/wiki/How-to-submit-your-iOS-app-to-App-Store
`, "utf8");
} else if (platform === 'android') {
cordovaProject.buildForPlatform(platform, buildOptions);

const apkPath = files.pathJoin(buildPath, 'build/outputs/apk',
options.debug ? 'android-debug.apk' : 'android-release-unsigned.apk')

0 comments on commit 88d43a0

Please sign in to comment.