Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider options for cached history. #34

Merged
merged 1 commit into from
Jul 23, 2015
Merged

Conversation

kueblboe
Copy link
Contributor

I am using the options parameter to pass filter and sort parameter for the search. If combined with a limit this returns incorrect results, when the search term (query) stays the same, but the filter or sort parameters are changed, since this doesn't trigger a new search on the server. To fix this I stringify the options and add them to the query to use as history key.

@arunoda
Copy link
Member

arunoda commented Jul 22, 2015

Okay. This is great.
This is what I want from #14

I'll take this.
So, this will be help to do pagination right?

@kueblboe
Copy link
Contributor Author

#14 is a bigger and more sophisticated issue which could happen on top of this. My simple change just fixes the issue that you cannot use the local history when you want to use sort or filter together with a limit. That's why I think this small change has value on its own.

@arunoda
Copy link
Member

arunoda commented Jul 22, 2015

Yes it is. That's why I like to take this in.

arunoda added a commit that referenced this pull request Jul 23, 2015
Consider options for cached history.
@arunoda arunoda merged commit d43ac8e into meteorhacks:master Jul 23, 2015
@viktorzp
Copy link

hi guys...)
pls tell me, is it possible to use pagination in this serch package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants