Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loggingOut as a reactive source #108

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Add loggingOut as a reactive source #108

merged 2 commits into from
Feb 11, 2023

Conversation

matheusccastroo
Copy link
Contributor

This PR adds the loggingOut function to see if a user is trying to logout. It's the counterpart of loggingIn.

matheusccastroo and others added 2 commits February 8, 2023 15:03
@matheusccastroo
Add loggingOut reactive function to track if the user is loggingOut o…
2bce01a 
…r not. This is the counter-part of loggingIn(). Also improve documentation and types.
@TheRealNate
Update package.json
6a1febb
TheRealNate
TheRealNate approved these changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@TheRealNate TheRealNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would recommend not changing version number in the future, as we should be doing that only when we want to push a new release.

@TheRealNate TheRealNate merged commit 12e162f into meteorrn:master Feb 11, 2023
@matheusccastroo
Copy link
Contributor Author

@TheRealNate Hey man, do you think it would be possible to release this?

@jankapunkt jankapunkt mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealNate TheRealNate TheRealNate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusccastroo @TheRealNate