-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced wolfy87-eventemitter with core EventEmtiter from 'events' #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
@jankapunkt can you resolve merge conflicts, GitHub keeps giving me issues |
@TheRealNate yes I will look at them |
@TheRealNate resolved |
Thanks @TheRealNate I will create a new release 2.5.0 and publish on NPM. |
@jankapunkt does this change require installing the npm package events? I am having problems running meteorrn without it but wanted to make sure this is the correct way. |
Hey @juanpmd I investigated and it seems to be a mistake from my end here. The tests never catched this, since they run with node, which itself holds |
implementes #112