-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor rn reachability url pr #120
Meteor rn reachability url pr #120
Conversation
Merge release 2.5.0 into master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run npm run lint
in order to fix the lint error. Apart from that it looks good to me
Tentatively approved, but @jankapunkt's changes should be done first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I will run the network scan today to see if I can confirm the behavior, too. If confirmed I will approve / merge.
I will get a new release 2.5.1 out asap |
Tested on iOS and android, on iOS I also checked via a proxy if, when using
reachabilityUrl
option, googles servers are no longer contacted.