Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strictly respect autoConnect flag #153

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: strictly respect autoConnect flag #153

merged 2 commits into from
Apr 17, 2024

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Feb 14, 2024

Summary

Fixes the issue where autoConnect: false did not 100% prevent auto-connect

Linked issue(s)

#150

Involved parts of the project

Meteor, DDP

Added tests?

Yes

Targeted Meteor release version

2.x

Reproduction

const endpoint = `ws://localhost:3000/websocket`;
Meteor.connect(endpoint, {
  AsyncStorage,
  NetInfo: null,
  autoConnect: false,
});
Meteor.getData().ddp.on('connected', () => console.debug('should never fire'))

@jankapunkt
Copy link
Member Author

@bratelefant I accidentally merged the other so this is a new PR, however I think this is even better, since the release will include this as an own bullet point in it's changelog later on

@jankapunkt
Copy link
Member Author

jankapunkt commented Feb 14, 2024

Published @meteorrn/core@2.8.1-rc.1 for testing (also bumped companion versions)

@jankapunkt jankapunkt linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link

Closing this PR due to no activity. Feel free to reopen.

@jankapunkt jankapunkt merged commit 768b9d0 into master Apr 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoConnect is broken
1 participant