Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to es6 #8

Merged
merged 22 commits into from
Nov 30, 2022
Merged

Refactor to es6 #8

merged 22 commits into from
Nov 30, 2022

Conversation

jankapunkt
Copy link
Member

This pr moves all code to ES6 and removes outdated dependencies where possible.

@jankapunkt jankapunkt self-assigned this Nov 4, 2022
@jankapunkt jankapunkt linked an issue Nov 4, 2022 that may be closed by this pull request
@jankapunkt jankapunkt marked this pull request as ready for review November 4, 2022 11:00
@jankapunkt
Copy link
Member Author

Hey @TheRealNate @diavrank I completely updated this library and replaced lodash with native ES6

If this gets released we can update the core to use this instead of the 6 years old minimongo and have nearly all vulnerabilities removed.

@jankapunkt jankapunkt changed the title Refactor to es6 (DRAFT!) Refactor to es6 Nov 4, 2022
@jankapunkt
Copy link
Member Author

@TheRealNate can you take a look at this? This is required to fix all these lodash issues that arise when install @meteorrn/core and minimongo-cache is somewhat abandoned so this is now our new updated minimongo cache with lodash replaced by native ES6.

Once this is published, for example as @meteorrn/minimongo then we can finalize the current PR on @meteorrn/core (meteorrn/meteor-react-native#99)

Copy link

@TheRealNate TheRealNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Merge when ready

@jankapunkt jankapunkt merged commit 6dff3ed into master Nov 30, 2022
@jankapunkt
Copy link
Member Author

Thank you @TheRealNate can you publish it to npm? We can then include it in meteorrn/meteor-react-native#99

@TheRealNate
Copy link

@jankapunkt Done. Theres a GH action setup to auto publish when a new release is declared, so you should be able to use that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete migration to ES6
2 participants