Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging needs to use a more specific file name #687

Closed
jgriesfeller opened this issue Jun 23, 2022 · 2 comments · Fixed by #702
Closed

logging needs to use a more specific file name #687

jgriesfeller opened this issue Jun 23, 2022 · 2 comments · Fixed by #702
Assignees
@jgriesfeller
Labels
aeroval-tools Issues related to AeroVal web tools

Comments

@jgriesfeller
Copy link
Member

The future paralleisation will start several aeroval jobs from the same work directory. The current logging to the file ./pyaerocom.log ends up in a scambled log file.
Because my qsub scripts log the console output to a specific file like /lustre/storeA/project/aerocom/logs/aeroval_logs/jang.20220621_101003.cfg_file_IASI.ULB_AeronetSDAV3L2.1657189_log.txt the general log file in in principle not needed at all (if the console output works). So we might want to get rid of that somehow with an option.

For discussion.
@jgriesfeller jgriesfeller added the aeroval-tools Issues related to AeroVal web tools label Jun 23, 2022
@jgriesfeller jgriesfeller self-assigned this Jun 23, 2022
@jgriesfeller jgriesfeller changed the title logging needs to become PID and hostname specific logging needs to use a more specific file name Jun 23, 2022
@avaldebe
Copy link
Collaborator

avaldebe commented Jun 23, 2022 •
edited
Loading

Maybe the name of the log file could be set up on an environmental variable, like PYAEROCOM_LOG_FILE.
When the variable is found the logging to file will activate, or the logging to file could be deactivated with PYAEROCOM_LOG_FILE="NONE".

@jgriesfeller
Copy link
Member Author

@avaldebe I support your proposal and would keep the current behavior as a default.

avaldebe added a commit to avaldebe/pyaerocom that referenced this issue Jul 13, 2022
@avaldebe
set log filename from env variable, close metno#687
f6aa47f
@avaldebe avaldebe mentioned this issue Jul 13, 2022
Merged
avaldebe added a commit to avaldebe/pyaerocom that referenced this issue Aug 2, 2022
@avaldebe
set log filename from env variable, close metno#687
96018ab
avaldebe added a commit to avaldebe/pyaerocom that referenced this issue Aug 22, 2022
@avaldebe
set log filename from env variable, close metno#687
4a62ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgriesfeller jgriesfeller

Labels
aeroval-tools Issues related to AeroVal web tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set log filename from environment variable avaldebe/pyaerocom
2 participants
@avaldebe @jgriesfeller