Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm add_to_project #1013

Merged
merged 1 commit into from
Feb 26, 2024
Merged

rm add_to_project #1013

merged 1 commit into from
Feb 26, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Feb 26, 2024

Close #1012

@lewisblake lewisblake self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (e1d826e) to head (9f6310c).
Report is 1510 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1013   +/-   ##
=========================================
  Coverage     78.95%   78.95%           
=========================================
  Files           105      105           
  Lines         18478    18478           
=========================================
  Hits          14590    14590           
  Misses         3888     3888           
Flag Coverage Δ
unittests 78.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a github automation change. It cannot be tested unless released and does not affect the functionality of the code itself, so review not required.

- uses: actions/add-to-project@v0.5.0
with:
project-url: https://github.com/orgs/metno/projects/12
github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the secrets.ADD_TO_PROJECT_PAT set?
Why only issues and not also PRs?

Copy link
Member Author

@lewisblake lewisblake Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it from the settings. The action was originally built to test on issues but didn't work, so I did not extend it to PRs.

@lewisblake lewisblake marked this pull request as ready for review February 26, 2024 09:06
@lewisblake lewisblake merged commit 8d067d3 into main-dev Feb 26, 2024
21 checks passed
@lewisblake lewisblake deleted the rm-add-to-project branch February 26, 2024 09:06
@heikoklein heikoklein added this to the m2024-03 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove add_to_project.yml and associated secret
2 participants